Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new incus_network_peer resource #157

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add new incus_network_peer resource #157

wants to merge 6 commits into from

Conversation

Unitiser
Copy link
Contributor

Hello,

This is the PR for #123.

@maveonair maveonair requested a review from stgraber November 11, 2024 08:08
@stgraber stgraber added the Incomplete Waiting on more information from reporter label Nov 25, 2024
@stgraber
Copy link
Member

stgraber commented Dec 3, 2024

@Unitiser any chance you can update your PR based on the comments above?
Also, we just merged #173 which comes with a few disabled tests that are waiting on this PR, it'd be great to add a commit which enables them.

@Unitiser
Copy link
Contributor Author

Hello, I apologize for the delay.

I made the fix you requested, hope this helps!

@maveonair maveonair removed the Incomplete Waiting on more information from reporter label Dec 16, 2024
@maveonair
Copy link
Member

@Unitiser Please merge origin main or rebase from origin main to get the latest fixes required for CI/CD to work.

maveonair
maveonair requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@maveonair maveonair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request must be above the latest main branch in order to receive the required corrections for CI/CD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maveonair maveonair maveonair requested changes

@stgraber stgraber Awaiting requested review from stgraber

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Unitiser @stgraber @maveonair